Fix keyboard shortcuts regression introduced in v1.2.0#189
Merged
thibaudcolas merged 2 commits intomasterfrom Mar 6, 2019
Merged
Fix keyboard shortcuts regression introduced in v1.2.0#189thibaudcolas merged 2 commits intomasterfrom
thibaudcolas merged 2 commits intomasterfrom
Conversation
…hortcuts were available unconditionally
…hortcuts were available unconditionally
thibaudcolas
force-pushed
the
bug/keyboard-shortcuts-regression
branch
from
124aff0 to
e51daf4
Compare
Collaborator
Generated by 🚫 dangerJS |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.0 changed what commands were created from default keyboard shortcuts defined within Draft.js. Unfortunately this part of the code wasn't overridden properly, and resulted in the commands being executed and styles activated when they shouldn't have been available.
This fixes the issue by always checking whether the command is enabled before applying it, and discarding commands that are not enabled.