This repository was archived by the owner on Apr 20, 2026. It is now read-only.
Fixes bug #76 Correct implementation of createAnnotatedTag().#77
Merged
Conversation
This puts the calls to the github api in the correct order and sets the commitsha on tag and reference so that an annotated tag is created in the git repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
============================================
+ Coverage 76.84% 76.86% +0.02%
- Complexity 296 297 +1
============================================
Files 42 42
Lines 1002 1003 +1
Branches 44 44
============================================
+ Hits 770 771 +1
Misses 207 207
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Contributor
|
Hi @solarhess. We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review. Thanks! Ellie |
sarlam
approved these changes
Jan 2, 2024
sarlam
left a comment
sarlam
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution to this library,
It looks good to me, let's move forward with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts the calls to the github api in the correct order and sets
the commitsha on tag and reference so that an annotated tag is created
in the git repository.