Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Add asAppScopedClient() function for convenience#196

Merged
Abhi347 merged 2 commits into
spotify:masterfrom
mitchhentgesspotify:mhentges/as-app-scoped-client
Sep 12, 2024
Merged

Add asAppScopedClient() function for convenience#196
Abhi347 merged 2 commits into
spotify:masterfrom
mitchhentgesspotify:mhentges/as-app-scoped-client

Conversation

@mitchhentgesspotify

@mitchhentgesspotify mitchhentgesspotify commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

It can be tricky to know which installation ID to provide to withScopeForInstallationId.
Rather than duplicating the "check for an organization installation, then check for a user installation", let's instead move that to this library so it can be reused.

This is a slow operation, but caching of the result can be handled by consumers (if needed) IMO.

@mitchhentgesspotify mitchhentgesspotify force-pushed the mhentges/as-app-scoped-client branch from bc76a8a to 178662d Compare September 11, 2024 13:36
@mitchhentgesspotify mitchhentgesspotify marked this pull request as ready for review September 11, 2024 13:39
@Abhi347 Abhi347 merged commit d62279a into spotify:master Sep 12, 2024
@mitchhentgesspotify mitchhentgesspotify deleted the mhentges/as-app-scoped-client branch September 12, 2024 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants