This repository was archived by the owner on Apr 20, 2026. It is now read-only.
chore: migrate to Junit 5#157
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
============================================
+ Coverage 75.83% 76.44% +0.60%
- Complexity 284 286 +2
============================================
Files 42 42
Lines 985 985
Branches 43 43
============================================
+ Hits 747 753 +6
+ Misses 212 207 -5
+ Partials 26 25 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to migrate to Junit 5. Even though we already used some Junit 5 tests, not all tests were migrated. This led to cases where not all tests could be discovered.
With the migration, I reduced the number of direct dependencies and abolished the need to depend on a few old dependencies. Namely, I updated Junit to use the Jupiter Engine and the Jupiter API, okhttp, Mockito, objenesis and the Surefire plugin. Furthermore, I removed the outdated Powermock dependencies because the mapping of final classes is now possible in Mockito.
Side note: Even though the used okhttp packages (
mockwebserverandokhttp) could be updated to version4.12.0, I discovered that they indirectly depend on different versions ofkotlin-stdlib-jdk8and just used version4.11.0.