Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Add support to get Installation identified by its installation id#151

Merged
felix-seifert merged 2 commits into
spotify:masterfrom
miwurster:installation-info
Dec 28, 2023
Merged

Add support to get Installation identified by its installation id#151
felix-seifert merged 2 commits into
spotify:masterfrom
miwurster:installation-info

Conversation

@miwurster

Copy link
Copy Markdown
Contributor

Hi, this PR adds support to get the an installation's information using the installation id. Essentially, it enables to use the /app/installations/{installation_id} API endpoint.

@ebk45

ebk45 commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Hi @miwurster.

We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review.

Thanks!

Ellie

@codecov

codecov Bot commented Dec 28, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24b73da) 76.64% compared to head (331bf5c) 76.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
+ Coverage     76.64%   76.69%   +0.04%     
- Complexity      289      290       +1     
============================================
  Files            42       42              
  Lines           989      991       +2     
  Branches         43       43              
============================================
+ Hits            758      760       +2     
  Misses          206      206              
  Partials         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miwurster

Copy link
Copy Markdown
Contributor Author

Rebased and ready for review.

@felix-seifert felix-seifert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and concise contribution. 👍

At first sight, I just had to think about what happens if calling the URL results in not finding the installation or gives another bad response. I then saw that this is handled in our GitHubClient and does not have to be tested several times.

Comment thread src/main/java/com/spotify/github/v3/clients/GithubAppClient.java Outdated
Comment thread src/main/java/com/spotify/github/v3/clients/GithubAppClient.java Outdated
@felix-seifert felix-seifert merged commit 97a1fc1 into spotify:master Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants