This repository was archived by the owner on Apr 20, 2026. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
============================================
+ Coverage 75.64% 75.66% +0.01%
- Complexity 279 281 +2
============================================
Files 42 42
Lines 969 978 +9
Branches 42 43 +1
============================================
+ Hits 733 740 +7
- Misses 211 212 +1
- Partials 25 26 +1
|
dziemba
approved these changes
Sep 14, 2023
Abhi347
reviewed
Sep 14, 2023
| public CompletableFuture<Reader> diff(final int number) { | ||
| final String path = String.format(PR_NUMBER_TEMPLATE, owner, repo, number); | ||
| final Map<String, String> extraHeaders = ImmutableMap.of( | ||
| HttpHeaders.ACCEPT, "application/vnd.github.diff" |
Contributor
There was a problem hiding this comment.
nit: Let's move "application/vnd.github.diff" to a constant up in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no support for getting the diff for a pullrequest. This is done by passing a certain header (
application/vnd.github.diff) which is done in this PR