This repository was archived by the owner on Apr 20, 2026. It is now read-only.
Serialize Annotation object with all required fields even empty#110
Merged
Conversation
Having JsonInclude:NON_EMPTY removes empty fields (e.g., "") When the required fields are removed, API calls fail due to missing fields in the request. Let's use less restrictive JsonInclude:NON_NULL annotation, which removes only null fields. Required fields are anyway non-nullable.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage 73.06% 73.06%
Complexity 245 245
=========================================
Files 39 39
Lines 880 880
Branches 39 39
=========================================
Hits 643 643
Misses 212 212
Partials 25 25
Help us with your feedback. Take ten seconds to tell us how you rate us. |
vchernodon
approved these changes
Aug 8, 2022
Abhi347
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having JsonInclude:NON_EMPTY removes empty fields (e.g., "")
When the required fields are removed, API calls fail due to missing
fields in the request.
Let's use less restrictive JsonInclude:NON_ABSENT annotation, which
removes only null & absent fields. Required fields are anyway non-nullable.
The failing test commit 5a1724f shows how NON_EMPTY rule works
^ from failed build logs