introduce ADT methods by andyglow · Pull Request #39 · spotify/dataenum

andyglow · 2023-09-12T23:14:09Z

adt methods are the default methods defined at Spec (interface) that's being copied over to the base adt class.

andyglow · 2023-09-12T23:15:59Z

hello @pettermahlen
please take a look at the change and the idea it implements. would you be open to accept it?

I think the example demonstrates what I am trying to achieve

pettermahlen · 2023-09-13T07:03:58Z

This also looks useful, could you update it so it works with #38, then I will merge it as well.

andyglow · 2023-09-14T00:09:57Z

@pettermahlen done. please at your convenience take another look

pettermahlen

Looks great, thanks!

pettermahlen · 2023-09-14T09:07:45Z

@andyglow it turns out that merging this has led to maven compilation failing. It's because the import com.sun.source.util.Trees statements (and others, I guess) fail to find classes formerly located in tools.jar. I haven't used Maven a lot in many years, and an hour or so of googling for solutions hasn't really helped. Is this something that you can help fix? If not, releasing will be hard.

andyglow · 2023-09-14T09:14:26Z

Well. I'm not a maven guy as well. But my research revealed that it gets compiled fine if you use Java up to 11. For Java 17 we need to specify a bunch of compiler options to allow unnamed modules access jdk.compile module. I couldn't find a way to make maven conditionally (if Java version is greater then X) apply compiler options. If applied non conditionally then compilation failed for java versions less then or equal to 11.

andyglow · 2023-09-14T09:14:52Z

Can you build it with Java 11?

pettermahlen · 2023-09-14T09:19:43Z

I am using Java 11: openjdk version "11.0.15" 2022-04-19 LTS.

andyglow · 2023-09-14T19:01:06Z

can you share logs please?

this is the version of java that I used to compile it

> java -version         
openjdk version "11.0.19" 2023-04-18
OpenJDK Runtime Environment Homebrew (build 11.0.19+0)
OpenJDK 64-Bit Server VM Homebrew (build 11.0.19+0, mixed mode)

pettermahlen · 2023-09-15T09:04:09Z

The relevant bits are

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project dataenum-processor: Compilation failure: Compilation failure:
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/MethodParser.java:[28,27] package com.sun.source.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/MethodParser.java:[39,56] cannot find symbol
[ERROR]   symbol:   class Trees
[ERROR]   location: class com.spotify.dataenum.processor.parser.MethodParser
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/ProcessingContext.java:[24,27] package com.sun.source.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/ProcessingContext.java:[32,16] cannot find symbol
[ERROR]   symbol:   class Trees
[ERROR]   location: class com.spotify.dataenum.processor.ProcessingContext
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/DataEnumProcessor.java:[36,27] package com.sun.source.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/DataEnumProcessor.java:[47,11] cannot find symbol
[ERROR]   symbol:   class Trees
[ERROR]   location: class com.spotify.dataenum.processor.DataEnumProcessor
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/MembersParser.java:[25,32] package com.sun.tools.javac.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/MembersParser.java:[44,10] cannot find symbol
[ERROR]   symbol:   class Pair
[ERROR]   location: class com.spotify.dataenum.processor.parser.MembersParser
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/SpecParser.java:[28,32] package com.sun.tools.javac.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[24,27] package com.sun.source.tree does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[25,27] package com.sun.source.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[26,27] package com.sun.source.util does not exist
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[62,63] cannot find symbol
[ERROR]   symbol:   class Trees
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[69,45] cannot find symbol
[ERROR]   symbol:   class TreePathScanner
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[71,28] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[73,35] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[77,74] cannot find symbol
[ERROR]   symbol:   class Trees
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[77,19] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[89,29] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/ProcessingContext.java:[37,18] cannot find symbol
[ERROR]   symbol:   variable Trees
[ERROR]   location: class com.spotify.dataenum.processor.ProcessingContext
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/DataEnumProcessor.java:[52,18] cannot find symbol
[ERROR]   symbol:   variable Trees
[ERROR]   location: class com.spotify.dataenum.processor.DataEnumProcessor
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/MembersParser.java:[112,15] cannot find symbol
[ERROR]   symbol:   class Pair
[ERROR]   location: class com.spotify.dataenum.processor.parser.MembersParser
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/parser/SpecParser.java:[60,11] cannot find symbol
[ERROR]   symbol:   class Pair
[ERROR]   location: class com.spotify.dataenum.processor.parser.SpecParser
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[63,11] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[80,23] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[82,7] cannot find symbol
[ERROR]   symbol:   class MethodTree
[ERROR]   location: class com.spotify.dataenum.processor.generator.method.MethodMethods.MethodLookup
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[88,5] method does not override or implement a method from a supertype
[ERROR] /Users/petter/opensource/dataenum/dataenum-processor/src/main/java/com/spotify/dataenum/processor/generator/method/MethodMethods.java:[91,14] non-static variable super cannot be referenced from a static context
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :dataenum-processor

pettermahlen · 2023-09-15T09:18:17Z

That was from mvn verify in the root.

Also, full version output from java -version:

openjdk version "11.0.15" 2022-04-19 LTS
OpenJDK Runtime Environment Corretto-11.0.15.9.1 (build 11.0.15+9-LTS)
OpenJDK 64-Bit Server VM Corretto-11.0.15.9.1 (build 11.0.15+9-LTS, mixed mode)

andyglow · 2023-09-15T21:06:34Z

@pettermahlen i see that you merged it, so you sorted the build issues out?

pettermahlen · 2023-09-18T08:27:25Z

No, unfortunately I merged before I noticed that there was an issue. We don't seem to have CI for this project..

andyglow · 2023-09-19T18:31:51Z

I see. Let me try to build with corretto

andyglow · 2023-10-11T21:16:42Z

@pettermahlen did you try to build it with java8?
I have a string filling that it wasn't supposed to be built by java11..
I tried to make it buildable by java11, but it required a lot of extra exercises with module.java stuff.

pettermahlen · 2023-10-13T11:27:14Z

After a long fight with rotten bits, I managed to create and deploy a release. 1.5.0 is now out, thanks for your contributions!

introduce adt methods

39ab435

andyglow changed the title ~~introduce adt methods~~ introduce ADT methods Sep 12, 2023

Andriy Onyshchuk and others added 3 commits September 13, 2023 17:02

address merge conflicts

ca6cc10

Merge branch 'master' into adt-methods

c4ceffc

format code

22c62ad

pettermahlen approved these changes Sep 14, 2023

View reviewed changes

pettermahlen merged commit 2ff451e into spotify:master Sep 14, 2023

pettermahlen mentioned this pull request Nov 24, 2023

dataenum:1.5.0 is not compiling #41

Open

Conversation

andyglow commented Sep 12, 2023

Uh oh!

andyglow commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pettermahlen commented Sep 13, 2023

Uh oh!

andyglow commented Sep 14, 2023

Uh oh!

pettermahlen left a comment

Choose a reason for hiding this comment

Uh oh!

pettermahlen commented Sep 14, 2023

Uh oh!

andyglow commented Sep 14, 2023

Uh oh!

andyglow commented Sep 14, 2023

Uh oh!

pettermahlen commented Sep 14, 2023

Uh oh!

andyglow commented Sep 14, 2023

Uh oh!

pettermahlen commented Sep 15, 2023

Uh oh!

pettermahlen commented Sep 15, 2023

Uh oh!

andyglow commented Sep 15, 2023

Uh oh!

pettermahlen commented Sep 18, 2023

Uh oh!

andyglow commented Sep 19, 2023

Uh oh!

andyglow commented Oct 11, 2023

Uh oh!

pettermahlen commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andyglow commented Sep 12, 2023 •

edited

Loading