Replace jsr250 with lib integrated in java#32
Merged
pettermahlen merged 1 commit intospotify:masterfrom Aug 13, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 95.64% 95.64%
Complexity 228 228
=========================================
Files 23 23
Lines 689 689
Branches 106 106
=========================================
Hits 659 659
Misses 22 22
Partials 8 8 Continue to review full report at Codecov.
|
pettermahlen
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Replace JSR 250 with Java SE library since Java6
Why
jsr250 and javax.annotation-api cover the same classes. Having both dependency create duplicated class for static analyzis of the dependencies. Using the Java SE library would make more sense to avoid this kind of issue.