Skip to content

Replace jsr250 with lib integrated in java#32

Merged
pettermahlen merged 1 commit intospotify:masterfrom
Kiramind:patch-1
Aug 13, 2020
Merged

Replace jsr250 with lib integrated in java#32
pettermahlen merged 1 commit intospotify:masterfrom
Kiramind:patch-1

Conversation

@Kiramind
Copy link
Contributor

Goal

Replace JSR 250 with Java SE library since Java6

Why

jsr250 and javax.annotation-api cover the same classes. Having both dependency create duplicated class for static analyzis of the dependencies. Using the Java SE library would make more sense to avoid this kind of issue.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage     95.64%   95.64%           
  Complexity      228      228           
=========================================
  Files            23       23           
  Lines           689      689           
  Branches        106      106           
=========================================
  Hits            659      659           
  Misses           22       22           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f34285...a6a3080. Read the comment docs.

@pettermahlen pettermahlen merged commit 761c0ed into spotify:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants