Skip to content

add support for copying annotations from spec to generated source#31

Merged
pettermahlen merged 3 commits intospotify:masterfrom
pettermahlen:annotations
Jul 1, 2019
Merged

add support for copying annotations from spec to generated source#31
pettermahlen merged 3 commits intospotify:masterfrom
pettermahlen:annotations

Conversation

@pettermahlen
Copy link
Member

This is needed in order to support lint checks that methods documented as deprecated
are also annotated as deprecated.

This is needed in order to support lint checks that methods documented as deprecated
are also annotated as deprecated.
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #31 into master will decrease coverage by 0.3%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     95.94%   95.64%   -0.31%     
- Complexity      222      228       +6     
============================================
  Files            23       23              
  Lines           666      689      +23     
  Branches        102      106       +4     
============================================
+ Hits            639      659      +20     
- Misses           20       22       +2     
- Partials          7        8       +1
Impacted Files Coverage Δ Complexity Δ
...m/processor/generator/data/OutputValueFactory.java 92.3% <100%> (+0.15%) 19 <0> (ø) ⬇️
...ava/com/spotify/dataenum/processor/data/Value.java 90.9% <100%> (+2.02%) 5 <2> (+1) ⬆️
...taenum/processor/generator/value/ValueMethods.java 100% <100%> (ø) 14 <0> (+1) ⬆️
...m/spotify/dataenum/processor/data/OutputValue.java 100% <100%> (ø) 13 <2> (+1) ⬆️
...spotify/dataenum/processor/parser/ValueParser.java 95.31% <81.25%> (-4.69%) 18 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b0faa...4c46c49. Read the comment docs.

@pettermahlen pettermahlen requested a review from togi June 28, 2019 10:22
@pettermahlen pettermahlen merged commit 0717d51 into spotify:master Jul 1, 2019
@pettermahlen pettermahlen deleted the annotations branch July 1, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant