Skip to content

Support incremental compilation with Gradle#17

Merged
pettermahlen merged 2 commits intospotify:masterfrom
pettermahlen:gradle-incremental
May 3, 2018
Merged

Support incremental compilation with Gradle#17
pettermahlen merged 2 commits intospotify:masterfrom
pettermahlen:gradle-incremental

Conversation

@pettermahlen
Copy link
Member

Gradle 4.7 introduced support for incremental compilation for well-behaved annotation
processors. This PR marks dataenum-processor as well-behaved and means Gradle chooses
incremental compilation if all other annotation processors also support incremental compilation.

This is necessary in order to enable incremental compilation with Gradle.
@pettermahlen pettermahlen requested a review from togi May 3, 2018 09:19
@codecov-io
Copy link

Codecov Report

Merging #17 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     93.54%   93.55%   +0.01%     
  Complexity      196      196              
============================================
  Files            23       23              
  Lines           620      621       +1     
  Branches         83       83              
============================================
+ Hits            580      581       +1     
  Misses           30       30              
  Partials         10       10
Impacted Files Coverage Δ Complexity Δ
...enum/processor/generator/spec/SpecTypeFactory.java 97.29% <100%> (+0.07%) 3 <0> (ø) ⬇️
.../spotify/dataenum/processor/DataEnumProcessor.java 92.85% <100%> (ø) 17 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53126e1...5a64172. Read the comment docs.

@pettermahlen pettermahlen merged commit 70c1a4d into spotify:master May 3, 2018
@pettermahlen pettermahlen deleted the gradle-incremental branch May 3, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants