Skip to content

Make IStore available via ISpecificationContext#2064

Merged
leonard84 merged 4 commits into
spockframework:masterfrom
leonard84:store-extensions
Dec 28, 2024
Merged

Make IStore available via ISpecificationContext#2064
leonard84 merged 4 commits into
spockframework:masterfrom
leonard84:store-extensions

Conversation

@leonard84

@leonard84 leonard84 commented Dec 28, 2024

Copy link
Copy Markdown
Member
  • Make IStore available via SpecificationContext
  • Change IBlockListener to receive...

@leonard84 leonard84 self-assigned this Dec 28, 2024
@leonard84 leonard84 changed the title store extensions Make IStore available via ISpecificationContext Dec 28, 2024
@leonard84 leonard84 marked this pull request as ready for review December 28, 2024 15:03
@leonard84

leonard84 commented Dec 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Since #1575 hasn't been released yet, I'm only adding a release notes entry for the store part.

@leonard84 leonard84 added this to the 2.4-M5 milestone Dec 28, 2024
@leonard84 leonard84 enabled auto-merge (squash) December 28, 2024 15:09
@leonard84
Make IStore available via SpecificationContext
77ddc5b
@leonard84
Change IBlockListener to receive...
a0b5c0f 
the current `Specification` instance instead of just the
`IterationInfo`.
This gives access to the `ISpecificationContext` as well
as potential fields.
For example, this could be used to trigger screenshots in a `Geb` spec.
@leonard84
Update Snapshots
d19ccbe
@leonard84
Add release notes
ca6ded6
@leonard84 leonard84 requested a review from AndreasTu December 28, 2024 15:24
AndreasTu
AndreasTu approved these changes Dec 28, 2024
View reviewed changes

@AndreasTu AndreasTu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leonard84 leonard84 merged commit 869542a into spockframework:master Dec 28, 2024
@codecov

codecov Bot commented Dec 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (2c7db77) to head (ca6ded6).
Report is 182 commits behind head on master.

Files with missing lines Patch % Lines
...ockframework/runtime/extension/IBlockListener.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2064      +/-   ##
============================================
+ Coverage     80.44%   81.90%   +1.45%     
- Complexity     4337     4688     +351     
============================================
  Files           441      452      +11     
  Lines         13534    14671    +1137     
  Branches       1707     1845     +138     
============================================
+ Hits          10888    12016    +1128     
+ Misses         2008     1975      -33     
- Partials        638      680      +42
Files with missing lines Coverage Δ
...java/org/spockframework/compiler/SpecRewriter.java 93.89% <100.00%> (+0.20%) ⬆️
...org/spockframework/runtime/PlatformSpecRunner.java 93.35% <100.00%> (-0.25%) ⬇️
...g/spockframework/runtime/SpecificationContext.java 100.00% <100.00%> (ø)
.../java/org/spockframework/runtime/SpockRuntime.java 84.18% <100.00%> (+4.05%) ⬆️
...java/org/spockframework/runtime/StoreProvider.java 100.00% <100.00%> (ø)
...ockframework/runtime/extension/IBlockListener.java 0.00% <0.00%> (ø)

... and 23 files with indirect coverage changes

@leonard84 leonard84 deleted the store-extensions branch December 28, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasTu AndreasTu AndreasTu approved these changes

Assignees

@leonard84 leonard84

Labels

None yet

Projects

None yet

Milestone

2.4-M5

Development

Successfully merging this pull request may close these issues.

2 participants

@leonard84 @AndreasTu