Properly fix possible deadlock, when blocking in mock response generators and fix fallout of #1885 (#583, #1899)#1910
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
leonard84
reviewed
Mar 7, 2024
leonard84
left a comment
leonard84
left a comment
Member
There was a problem hiding this comment.
Not sure if I'll have the time for a release before Sunday.
AndreasTu
reviewed
Mar 7, 2024
AndreasTu
previously approved these changes
Mar 8, 2024
leonard84
reviewed
Mar 10, 2024
Vampire
force-pushed
the
vampire/issue-583
branch
from
bbf7e5d to
01d7eb8
Compare
leonard84
previously approved these changes
Mar 11, 2024
AndreasTu
previously approved these changes
Mar 12, 2024
Vampire
force-pushed
the
vampire/issue-583
branch
from
eaf7667 to
4e8b3ca
Compare
leonard84
force-pushed
the
vampire/issue-583
branch
from
4e8b3ca to
4a4a4af
Compare
leonard84
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes of PR #1885 and hopefully fixes #583, #1882, and #1899 properly
without the fallout of the previous PR.
All interaction handling stays synchronized, but the response generation happens unsynchronized.
As said in #1885, I think this should immediately be released as 2.4-M3 if it passes review as in M2 the whole interaction handling is highly broken in any multi-threaded situation.