JSONResultsReader added and deprecated ResultsReader #441
Merged
ashah-splunk merged 5 commits intodevelopfrom Mar 23, 2022
Merged
JSONResultsReader added and deprecated ResultsReader #441ashah-splunk merged 5 commits intodevelopfrom
ashah-splunk merged 5 commits intodevelopfrom
Conversation
Contributor
ashah-splunk
commented
Mar 15, 2022
ashah-splunk
commented
- Added user's approach for JSONResultsReader in place of ResultsReader
- Newer approach increase efficiency and performance
- Modified test cases, examples and documentation to use JSONResultsReader along with query param 'output_mode' set to 'json' to use the newer approach
- Added deprecation warning for the ResultsReader
fantavlik
approved these changes
Mar 22, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
This looks good! One minor comment - the ResultsReader import in examples/stail.py can be removed.
fantavlik
reviewed
Mar 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.