added setup_logging() method in splunklib for logging and updated README.md files#437
Merged
akaila-splunk merged 3 commits intodevelopfrom Mar 4, 2022
Merged
added setup_logging() method in splunklib for logging and updated README.md files#437akaila-splunk merged 3 commits intodevelopfrom
akaila-splunk merged 3 commits intodevelopfrom
Conversation
Contributor
akaila-splunk
commented
Mar 3, 2022
- Used module-specific logger in splunklib code instead of root logger
- Added new setup_logging() method in splunklib to set logging level, log format(optional) and date format(optional)
- Updated REAME.md file with details of setup_logging() method
- Updated searchcommands_app/README.md file with some details of logging.conf file and how to see debug logs
- Here is an example of log message,
- add default time and log formatter in setup_logging() method - add details of setup_logging() method and logging.conf files in README.md file
fantavlik
approved these changes
Mar 4, 2022
Contributor
fantavlik
left a comment
There was a problem hiding this comment.
Well done! Thanks for walking us through the design along the way on our weekly syncs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.