properly add parameters to request based on the method of the request#262
Merged
ashah-splunk merged 2 commits intosplunk:developfrom Dec 15, 2021
Merged
Conversation
shakeelmohamed
suggested changes
Jul 26, 2019
Contributor
shakeelmohamed
left a comment
shakeelmohamed
left a comment
There was a problem hiding this comment.
Thanks for the PR @billmurrin, we will take a look at sorting out the CI issue
Contributor
Author
|
Hi @shakeelmohamed. I've implemented the requested changes in the latest commit. Thanks! |
Contributor
Author
|
Hi @shakeelmohamed - the requested changes were made. For some reason, the CI issue is still ongoing. |
Contributor
|
@billmurrin This is not a high priority issue for us to investigate as we are severely under resourced at the moment. Unless this is 10/10 we will not look at it this week. Thank you for your patience & understanding. cc @tdhellmann |
|
Any news here? We are looking forward to get this fix too! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #261 related to improper handling of
bodyparameters within theContext.requestmethod. The method used (GETorPOST) will determine if the body is encoded as part of the url or passed as body into the request.GET method requests (with and without a body) were tested and worked as expected.