Potential fix for code scanning alert no. 4: Workflow does not contain permissions#55
Closed
exequielloza wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#55exequielloza wants to merge 1 commit into
exequielloza wants to merge 1 commit into
Conversation
…n permissions https://splight.atlassian.net/browse/SECUR-434 Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Exequiel Loza <exequiel.loza@splight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/splightplatform/splight-agent/security/code-scanning/4
In general, the fix is to explicitly restrict the GITHUB_TOKEN permissions using a
permissions:block, either at the workflow root (applies to all jobs) or individually per job, granting only what is needed. These jobs only need to read repository contents to run code formatters and version checks, socontents: readis sufficient.The best fix here is to add a single top-level
permissions:block after thename(oron) key in.github/workflows/developer.yaml, settingcontents: read. This will apply to all three jobs (black,isort,verify-version) that currently lack permissions, without changing their functionality, since they only read repository files. No additional imports, methods, or definitions are needed; this is purely a YAML configuration change within the workflow file.Concretely: in
.github/workflows/developer.yaml, between line 1 (name: Code Quality) and line 2 (on: pull_request), insert:leaving the rest of the workflow unchanged.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.