Report latency from agent to api#53
Closed
thvadora wants to merge 1 commit into
Closed
Conversation
| self._report_agent_version() | ||
| self._exporter.start() | ||
| self._beacon.start() | ||
| self._latency_reporter.start() |
Contributor
There was a problem hiding this comment.
I would add this functionality into the "Beacon" process, that already does a ping to a healtcheck endpoint
Author
There was a problem hiding this comment.
I thought about that but the beacon responsability is different and I didn't want to couple responsabilities. But if you still think that puting it in the beacon, I can do it tomorrow. let me know
Contributor
There was a problem hiding this comment.
The beacon is responsible for making a "keep alive" ping, so as part of that keep alive process we can add the report of the latency, I don't see it like problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small telemetry report, but it will be useful later in the roadmap when we begin work on TR-151. It will help us evaluate whether certain self-hosted node configurations perform better than others in terms of network latency.
For context: later this year, we'll be testing whether running the splight-agent on an edge router with a Hologram.io eSIM is reliable enough to scale DCM operations. While that's a future step, this latency metric is being added now so we have it ready when the time comes.
Important: Do not merge this before the corresponding PR in engine-v4 is merged.