Core 341. Wrap all stable math ops to prevent unsafe calls#114
Open
Bromel777 wants to merge 1 commit into
Open
Core 341. Wrap all stable math ops to prevent unsafe calls#114Bromel777 wants to merge 1 commit into
Bromel777 wants to merge 1 commit into
Conversation
Bromel777
force-pushed
the
core-341-wrap-all-stable-math-ops-to-prevent-unsafe-calls
branch
3 times, most recently
from
0d6a928 to
527c561
Compare
Bromel777
force-pushed
the
core-341-wrap-all-stable-math-ops-to-prevent-unsafe-calls
branch
from
527c561 to
03e0371
Compare
oskin1
reviewed
Jul 19, 2024
Comment on lines
+548
to
+557
| U512::from((self.reserves_x - self.treasury_x).untag() * self.multiplier_x), | ||
| U512::from((self.reserves_y - self.treasury_y).untag() * self.multiplier_x), | ||
| U512::from(self.an2n), | ||
| ) | ||
| .expect( | ||
| format!( | ||
| "Invariant calculated incorrectly. calculate_invariant({}, {}, {})", | ||
| U512::from((self.reserves_x - self.treasury_x).untag() * self.multiplier_x), | ||
| U512::from((self.reserves_y - self.treasury_y).untag() * self.multiplier_x), | ||
| U512::from(self.an2n), |
Contributor
There was a problem hiding this comment.
Why repeating calculations? Bind them and reuse.
Bromel777
force-pushed
the
core-341-wrap-all-stable-math-ops-to-prevent-unsafe-calls
branch
2 times, most recently
from
6cec840 to
ef5e874
Compare
Bromel777
force-pushed
the
core-341-wrap-all-stable-math-ops-to-prevent-unsafe-calls
branch
2 times, most recently
from
7703eae to
92852ab
Compare
Wrap stable pool math with Option<..>
Bromel777
force-pushed
the
core-341-wrap-all-stable-math-ops-to-prevent-unsafe-calls
branch
from
92852ab to
43698c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.