CORE-152. Available liquidity at target price#103
Merged
Conversation
Bromel777
force-pushed
the
core-152-avaliable-liquidity
branch
from
8f246e7 to
86009b4
Compare
… price in cfmm/balance pools. -------------- Co-authored-by: AOranov <a.oranov@spectrumlabs.fi>
Bromel777
force-pushed
the
core-152-avaliable-liquidity
branch
from
86009b4 to
47e33ef
Compare
oskin1
reviewed
Jun 25, 2024
| /// How much (approximately) execution of this fragment will cost. | ||
| fn marginal_cost_hint(&self) -> Self::U; | ||
|
|
||
| fn available_liquidity(&self, max_price_impact: Side<Ratio<u128>>) -> (u128, u128); |
Contributor
There was a problem hiding this comment.
What is this tuple in return position? Why u128?
Comment on lines
+542
to
+551
| println!( | ||
| "{:?}", | ||
| <u128>::try_from( | ||
| (total_fee_mult.clone() * BigNumber::from(100000)) | ||
| .value | ||
| .to_int() | ||
| .value() | ||
| ) | ||
| .unwrap() | ||
| ); |
oskin1
pushed a commit
that referenced
this pull request
Jun 25, 2024
… price in cfmm/balance pools. (#103) -------------- Co-authored-by: AOranov <a.oranov@spectrumlabs.fi>
oskin1
pushed a commit
that referenced
this pull request
Jul 2, 2024
… price in cfmm/balance pools. (#103) -------------- Co-authored-by: AOranov <a.oranov@spectrumlabs.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arget price in cfmm/balance pools.