Skip to content

Remove Redundant "Unknown-Flag" Error #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasaschan merged 3 commits into from
Jul 17, 2025
Merged

Remove Redundant "Unknown-Flag" Error #364

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a9275f
Remove Redundant "Unknown-Flag" Error
vaguecoder Nov 19, 2022
5159cda
Ensure output is written to correct stream
tomasaschan Jul 17, 2025
391036c
Ensure output is written also from ParseAll
tomasaschan Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,6 @@ func VarP(value Value, name, shorthand, usage string) {
func (f *FlagSet) failf(format string, a ...interface{}) error {
err := fmt.Errorf(format, a...)
if f.errorHandling != ContinueOnError {
fmt.Fprintln(f.Output(), err)
f.usage()
}
return err
Expand Down Expand Up @@ -1151,7 +1150,7 @@ func (f *FlagSet) Parse(arguments []string) error {
case ContinueOnError:
return err
case ExitOnError:
fmt.Println(err)
fmt.Fprintln(f.Output(), err)
os.Exit(2)
case PanicOnError:
panic(err)
Expand All @@ -1177,6 +1176,7 @@ func (f *FlagSet) ParseAll(arguments []string, fn func(flag *Flag, value string)
case ContinueOnError:
return err
case ExitOnError:
fmt.Fprintln(f.Output(), err)
os.Exit(2)
case PanicOnError:
panic(err)
Expand Down
Loading