Fix SPDX format writer loosing relationships#877
Open
Rainer-Keller wants to merge 1 commit intospdx:mainfrom
Open
Fix SPDX format writer loosing relationships#877Rainer-Keller wants to merge 1 commit intospdx:mainfrom
Rainer-Keller wants to merge 1 commit intospdx:mainfrom
Conversation
The relationships were only added if a file information was not already written to the output writer. In all other cases, the relationship got lost. Moving the writing of the relationship outside of the if statement makes it write the relationship info in all cases. The test cases for tagvalue_write did also declare relationships, but the validation data was missing them. Signed-off-by: Rainer Keller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relationships were only added if a file information was not already written to the output writer. In all other cases, the relationship got lost without notice.
In my opinion this is a very serious issue because it invalidates the content of the written SBOM without the user noticing.
The two test cases of the
tagvalue_writeralso had relationships declared in their setup, but missing them in the validated output content.