pyproject: Use pyproject.toml for building wheels

[abelgladstone]

Remove setup.py and move to pyproject.toml

[pep8speaks]

Hello @abelgladstone! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file _custom_build/backend.py:

Line 22:80: E501 line too long (87 > 79 characters)
Line 23:80: E501 line too long (96 > 79 characters)
Line 38:80: E501 line too long (101 > 79 characters)
Line 39:80: E501 line too long (82 > 79 characters)
Line 46:80: E501 line too long (80 > 79 characters)
Line 47:80: E501 line too long (89 > 79 characters)
Line 49:80: E501 line too long (99 > 79 characters)
Line 52:80: E501 line too long (123 > 79 characters)
Line 54:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-10-11 13:58:22 UTC

[mgeier]

Thanks for this PR!

I like this approach in general, but it seems that the "cross-platform package creation" doesn't work anymore.
This means that the CI doesn't create platform-specific wheels anymore:

python-sounddevice/.github/workflows/publish.yml

Lines 18 to 19 in 2748f70

	- name: Build binary wheels and a source tarball
	run: ./make_dist.sh

[abelgladstone]

@mgeier thank you for the reply. I will try make an effort to get the platform specific builds to work as well. Will get back to you soon.

[abelgladstone]

Unfortunately my little home PC is stuck on windows the output filename is as expected on a win64_amd64.

The make_dist script works as expected.

As a consequence of intercepting the filename. I had to move the version to a separate VERSION file. So that I can read it without any fuss. I hope that this is acceptable.

BTW Thank you for a wonderful little library. I cannot tell you how much I use this.

[mgeier]

Thanks for the quick update!

I need some more time to review and test this thoroughly, but in the meantime I was wondering whether we should enable building the wheels on PRs: #561. Because otherwise we don't know whether this PR really works, right?

[mgeier]

I guess this should be ...

Suggested change

	def prepare_meta_for_build_wheel(config_settings=None):
	def prepare_metadata_for_build_wheel(config_settings=None):

... but the whole function seems unnecessary, since it is imported already?

[abelgladstone]

Agreed.

[mgeier]

I've merged #561, can you please rebase this PR?

[abelgladstone]

Done

[mgeier]

Thanks!

The wheels are available here: https://github.com/spatialaudio/python-sounddevice/actions/runs/11293700433?pr=560

Now all of them contain all binaries, but each should only contain the binaries for their own platform.

[mgeier]

I guess this causes all wheels to contain all binaries. This should be limited.

Also, the sdist now also contains the binaries, but it shouldn't.

[abelgladstone]

Thanks for the review. I'll get back to you soon.

[abelgladstone]

After many tries I am unable to find a way to build the project without the setup.py file in which case what is in the project is already good enough IMO.

[mgeier]

Thanks a lot for your efforts anyway!

AFAIU, the problem is that package-data cannot be set dynamically depending on the platform, while that is possible in setup.py with package_data.

Maybe future changes to setuptools will make this possible, or maybe we'll find a different build tool that supports this.

If anyone has an idea, please speak up!

[mgeier]

I'm closing this for now, but if anyone has an idea how to make this work, please let me know!