Fix feature variable name in template config file#114
Closed
lbn-chef-team wants to merge 1 commit into
Closed
Conversation
replace "feature" variable name with "feature_list" in some case in _ConfigurationFile.ini.erb file. This syntax error impede the cookbook to run install of 2016 or 2017 versions of MSSQL Server with the following error: undefined method `include?' for nil:NilClass.
Contributor
|
@lbn-chef-team Thank you for submitting this PR but as a requirement of contributing to the repo we require your PR to be signed. If you could take care of that it would be greatly appreciated. Thank you. |
Contributor
Author
|
yes! sorry for that, i'll take care henceforth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace "feature" variable name with "feature_list" in some case in _ConfigurationFile.ini.erb file. This syntax error impede the cookbook to run install of 2016 or 2017 versions of MSSQL Server with the following error: undefined method `include?' for nil:NilClass.
Description
Fix this error: FATAL: Chef::Mixin::Template::TemplateError: undefined method `include?' for nil:NilClass
Template Context:
on line #330
328:
329: <% if @Version == '2016' %>
330: <% if @feature.include?('ADVANCEDANALYTICS' || 'SQL_SHARED_MR') %>
331: IACCEPTROPENLICENSETERMS=<%= @accept_eula %>
332:
System Info:
chef_version=13.0.118
platform=windows
platform_version=6.3.9600
ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]
Issues Resolved
[List any existing issues this PR resolves]
Check List