Add indexing tests on schemas / collection id duplication#828
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR expands the CLI indexing test suite to cover cases where schema routing would otherwise hit duplicated path segments. Changes:
Technical Notes: These tests help prevent regressions where collection IDs and schema-derived paths collide or are mishandled during index generation. 🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: ab907f0 | Previous: 2b5a294 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
22 ms |
19 ms |
1.16 |
Add one schema (100 existing) |
23 ms |
24 ms |
0.96 |
Add one schema (1000 existing) |
75 ms |
73 ms |
1.03 |
Add one schema (10000 existing) |
882 ms |
630 ms |
1.40 |
Update one schema (1 existing) |
16 ms |
16 ms |
1 |
Update one schema (101 existing) |
23 ms |
23 ms |
1 |
Update one schema (1001 existing) |
80 ms |
75 ms |
1.07 |
Update one schema (10001 existing) |
914 ms |
635 ms |
1.44 |
Cached rebuild (1 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (101 existing) |
11 ms |
11 ms |
1 |
Cached rebuild (1001 existing) |
31 ms |
31 ms |
1 |
Cached rebuild (10001 existing) |
260 ms |
243 ms |
1.07 |
Index 100 schemas |
133 ms |
105 ms |
1.27 |
Index 1000 schemas |
951 ms |
989 ms |
0.96 |
Index 10000 schemas |
12954 ms |
13133 ms |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: ab907f0 | Previous: 2b5a294 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
19 ms |
20 ms |
0.95 |
Add one schema (100 existing) |
25 ms |
24 ms |
1.04 |
Add one schema (1000 existing) |
74 ms |
75 ms |
0.99 |
Add one schema (10000 existing) |
853 ms |
855 ms |
1.00 |
Update one schema (1 existing) |
18 ms |
19 ms |
0.95 |
Update one schema (101 existing) |
25 ms |
24 ms |
1.04 |
Update one schema (1001 existing) |
76 ms |
75 ms |
1.01 |
Update one schema (10001 existing) |
840 ms |
809 ms |
1.04 |
Cached rebuild (1 existing) |
10 ms |
10 ms |
1 |
Cached rebuild (101 existing) |
13 ms |
12 ms |
1.08 |
Cached rebuild (1001 existing) |
32 ms |
33 ms |
0.97 |
Cached rebuild (10001 existing) |
321 ms |
296 ms |
1.08 |
Index 100 schemas |
112 ms |
114 ms |
0.98 |
Index 1000 schemas |
1005 ms |
1107 ms |
0.91 |
Index 10000 schemas |
13080 ms |
13140 ms |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com