version 0.3.15#392
Merged
Merged
Conversation
varungandhi-src
approved these changes
Jan 7, 2025
varungandhi-src
left a comment
varungandhi-src
left a comment
Contributor
There was a problem hiding this comment.
Looks like this didn't publish anything, so this is OK. However, the current CI setup has the unfortunate potential failure mode where you can publish the NPM package successfully, and then fail to publish the Docker image. In that case, deleting the tag + recreating it increases the risk of confusion.
It might be simpler to instead always treat tags as immutable (including for releases which failed to publish), and simply document them as failed in the CHANGELOG.
Contributor
Author
Yes, that's the only reason I deleted the tag – because nothing was published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tagged release failed, so updating version manually (I deleted the tag and will re-create after this PR)
Test plan
N/A