Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Switch CI to 3.5-stretch base image#54

Merged
PeterJCLaw merged 1 commit intosourcebots:masterfrom
PeterJCLaw:update-ci
Apr 19, 2019
Merged

Switch CI to 3.5-stretch base image#54
PeterJCLaw merged 1 commit intosourcebots:masterfrom
PeterJCLaw:update-ci

Conversation

@PeterJCLaw
Copy link
Copy Markdown
Contributor

The jessie base images don't work for us now that jessie's deb repos have been archived.

@RealOrangeOne
Copy link
Copy Markdown
Member

Is the only diff here meant to just be a newline?

@PeterJCLaw
Copy link
Copy Markdown
Contributor Author

oops, no. not sure what happened there. It should have been a copy of sourcebots/robot-api#108. Will fix, probably via force-push so the commit messages make sense.

The jessie base images don't work for us now that jessie's deb
repos have been archived.
@kierdavis
Copy link
Copy Markdown
Member

CI fails on a couple of linting errors, but those files aren't touched by this PR. My guess is that the linter has updated in the last 8 months since the last CI run and has gotten stricter. I'm fine if you want to merge this and create a new issue or PR to track the linting errors.

For future reference, if you push to a branch within this repository rather than in a fork, CircleCI will run on it and attach the results to the PR. It's done it here only because I copied your branch to this repository (under the name PeterJCLaw-update-ci). Shout if you don't have access to create branches on here.

@PeterJCLaw
Copy link
Copy Markdown
Contributor Author

For future reference, if you push to a branch within this repository rather than in a fork, CircleCI will run on it and attach the results to the PR. It's done it here only because I copied your branch to this repository (under the name PeterJCLaw-update-ci). Shout if you don't have access to create branches on here.

Ah, we should definitely fix that as otherwise it makes it harder for people outside the org to contribute. There's a toggle in Circle which enables building PRs outside the main repo, I'll see if I can find it.

@PeterJCLaw
Copy link
Copy Markdown
Contributor Author

For future reference, if you push to a branch within this repository rather than in a fork, CircleCI will run on it and attach the results to the PR. It's done it here only because I copied your branch to this repository (under the name PeterJCLaw-update-ci). Shout if you don't have access to create branches on here.

Ah, we should definitely fix that as otherwise it makes it harder for people outside the org to contribute. There's a toggle in Circle which enables building PRs outside the main repo, I'll see if I can find it.

I've now toggled this.

@kierdavis
Copy link
Copy Markdown
Member

There's a toggle in Circle which enables building PRs outside the main repo

I wasn't aware that was a thing, but that's a better solution, thanks.

@PeterJCLaw PeterJCLaw merged commit 6ff46f0 into sourcebots:master Apr 19, 2019
@PeterJCLaw PeterJCLaw deleted the update-ci branch April 19, 2019 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants