This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Collect the board lists only when needed#80
Merged
PeterJCLaw merged 1 commit intomasterfrom Feb 18, 2018
Merged
Conversation
This ensures that they actually contain the lists of boards at this point, thus ensuring that we properly close off the boards. Note: while it might be assumed that this could be done upfront, we reassign the `self.known*boards` attributes when adding boards, meaning that the upfront collection will only reflect the initial (empty) lists.
Open
RealOrangeOne
approved these changes
Feb 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that they actually contain the lists of boards at this point, thus ensuring that we properly close off the boards.
Note: while it might be assumed that this could be done upfront, we reassign the
self.known*boardsattributes when adding boards, meaning that the upfront collection will only reflect the initial (empty) lists.Note: the issues this fixes is also resolved by #79, though I think we still want this change for clarity.