fix(web): remove router.refresh() after router.push() to fix Next.js 16 navigation#974
Merged
brendan-kellam merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
…16 navigation In Next.js 16, the prefetch cache and navigation system was completely rewritten. Calling router.refresh() immediately after router.push() creates a race condition where the cache invalidation interrupts the in-flight navigation, causing the page to not load. Removed the router.refresh() calls from: - useCreateNewChatThread.ts - chatName.tsx - chatSidePanel.tsx - inviteMemberCard.tsx Also documents this pattern in CLAUDE.md to prevent future regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
💤 Files with no reviewable changes (4)
WalkthroughRemoves Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
router.refresh()called immediately afterrouter.push()to race and interrupt the in-flight navigation — leaving the page stuck or not loadingrouter.refresh()calls fromuseCreateNewChatThread.ts,chatName.tsx,chatSidePanel.tsx, andinviteMemberCard.tsxCLAUDE.mdto prevent future regressionsTest plan
/chatsucceeds?tab=invitesworks correctly🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation