Skip to content

add new global search params (vault_scope and entities_match)#414

Merged
davecap merged 8 commits into
masterfrom
add-new-search-params
May 5, 2022
Merged

add new global search params (vault_scope and entities_match)#414
davecap merged 8 commits into
masterfrom
add-new-search-params

Conversation

@davecap

@davecap davecap commented May 5, 2022

Copy link
Copy Markdown
Contributor
  • Adds missing global search params (vault_scope, entities_match)
  • Fix issue with querying objects directly from search results
  • Fix issue with test environment dependencies

@davecap
davecap requested a review from just-krivi May 5, 2022 17:37

@just-krivi just-krivi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Only to add vault_scope and entities_match to the docstring of the contructor.

@davecap

davecap commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Also fixes issue with running result.query() directly on a constructed Global Search result.

@davecap

davecap commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Also fixes this: plotly/dash#1992

@davecap
davecap merged commit a76e656 into master May 5, 2022
@davecap
davecap deleted the add-new-search-params branch May 5, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants