This repository was archived by the owner on Aug 24, 2019. It is now read-only.
Fix comment, +minor changes#3
Open
jlnr wants to merge 2 commits intosoffes:masterfrom
jlnr:master
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAMLabel is a cool little pod that I like to use from time to time. Thanks!
I've mostly opened this PR to fix an inconsistent enum comment. I've also removed the
@synthesizelines which are automatic now.One thing that I'm not too sure about is the initialization. I'm wary of methods with generic names like
initializebecause someone else in the class hierarchy might accidentally use the same name. I thought about renaming it to something more unique, but instead I've inlined the methods in both constructors. Since theUIEdgeInsetsis fine being 0-initialized, only one assignment is necessary.If you think that this is actually more fragile than before, I can revert that part :)