Fixing no-std support by making thiserror optional and added test#28
Closed
TKFRvisionOfficial wants to merge 2 commits intosmessmer:masterfrom
Closed
Fixing no-std support by making thiserror optional and added test#28TKFRvisionOfficial wants to merge 2 commits intosmessmer:masterfrom
TKFRvisionOfficial wants to merge 2 commits intosmessmer:masterfrom
Conversation
- made thiserror optional
TKFRvisionOfficial
changed the title
Contributor
Author
|
The test I added ensures compatibility with no-std by compiling to thumbv6m-none-eabi, an architecture without std support. |
Closed
Owner
|
merged. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ln version 4.0 the thiserror dependency was added to the library. thiserror isn't no-std compatible, and indeed was disabled in the code using the cfg macro. Sadly it wasn't made optional in the cargo.toml which means that is always compiled, even if the std feature of binary-layout has been disabled.