SMTP without authentication, workaround touch API, use store theme settings for mail styling#1503
Conversation
Some SMTP servers in local networks do not need authentication to accept e-mails for relaying.
Mouse clicks to not close flyout menus when it is on a touch enabled device. Add close buttons to flyout menus.
muratcakir
left a comment
muratcakir
left a comment
There was a problem hiding this comment.
- Placement of closer is not optimal.
- Letter "X" is not a good choice for a closing button. Use an icon or the "×" char instead
muratcakir
left a comment
muratcakir
left a comment
There was a problem hiding this comment.
There's a good reason why we didn't do that:
- It's not always guaranteed that every theme shares the same variables.
- E-Mails - due to some shitty clients - require a totally different styling approach
|
What would be a better placement for a Closer? |
It just doesn't look good in the upper tabstrip. Besides, it squashes the tab labels and cuts them in other languages with longer labels. I have no idea where to place it in a hurry. |
Use times character instead of X character. Place closer link outside nav menu.
|
The closer now uses times character and is placed outside the nav menu. While my test I have seen that when the screen width is very small the offcanvas-cart menu uses the whole width and therefore the closer is also needed to close the offcanvas-cart without the need of reloading the site. Please check my new suggestion and if you have any ideas to make it looking better please share it with me. |
muratcakir
left a comment
muratcakir
left a comment
There was a problem hiding this comment.
I would like to merge your pull request, but without the nav-closer stuff. Could you please remove it, we need a better approach for that. Actually, best way would be to fix the issue on convertible devices.
|
I have removed the closer and have done a deeper look into the smartstore.offcanvas.js script which is responsible for the menu functionality. I have changed the hiding trigger event from "tap" to "click" and now it works on all device classes (mouse, touch, mixed). I have seen on small devices where the menu uses the whole width that you can close the menu with a swipe gesture. I think this is a good solution for small devices because I think they all have touch screens. |
|
Should I also revert the mail styling thing for the moment? |
Yes, please. |
This reverts commit 9a13c00.
|
I have reverted the mail styling thing. |
2 participants
No description provided.