fix: prevent TNT minecarts from exploding if TNT host option is disabled#921
Merged
codeHusky merged 1 commit intosmartcmd:mainfrom Mar 8, 2026
Merged
Conversation
Contributor
Author
Minecraft.2026-03-08.03-37-22.2.mp4 |
Contributor
|
Nice find 🧠 |
retroohmygod
pushed a commit
to retroohmygod/astrasmcfork
that referenced
this pull request
Mar 8, 2026
piebotc
pushed a commit
to piebotc/LegacyEvolved
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a gameplay inconsistency where TNT Minecarts would ignore the "TNT Explodes" host option, allowing them to explode even when TNT was disabled for the world.
Changes
Previous Behavior
TNT Minecarts would always explode regardless of the world's host settings. This allowed for accidental or intentional griefing in worlds where the host specifically disabled TNT.
Root Cause
The
MinecartTNT::explodefunction lacked a check for theeGameHostOption_TNTflagNew Behavior
TNT Minecarts now respect the TNT explodes option.
Fix Implementation
Wrapped the explosion and entity removal logic inside a conditional check for
app.GetGameHostOption(eGameHostOption_TNT)AI Use Disclosure
No
Related Issues