Fix stale held item appearing when switching worlds#910
Merged
smartcmd merged 1 commit intosmartcmd:mainfrom Mar 8, 2026
Merged
Fix stale held item appearing when switching worlds#910smartcmd merged 1 commit intosmartcmd:mainfrom
smartcmd merged 1 commit intosmartcmd:mainfrom
Conversation
Signed-off-by: Ayush Thoren <ayushthoren@gmail.com>
piebotc
pushed a commit
to piebotc/LegacyEvolved
that referenced
this pull request
Mar 9, 2026
Signed-off-by: Ayush Thoren <ayushthoren@gmail.com>
Kamenkovic
pushed a commit
to Kamenkovic/FpsLimit
that referenced
this pull request
Mar 9, 2026
Signed-off-by: Ayush Thoren <ayushthoren@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a visual glitch where, when switching worlds, the previously held item could be visible for a bit before the new world's player state was applied.
Changes
Previous Behavior
The code would fail to clean up the player's held item state when exiting a world.
Root Cause
ItemInHandRenderercached held item states (selectedItem,lastSlot, and equip animation values) that persisted across world transitions and were reused before the new world's state fully propagated.New Behavior
Worlds now load with a cleared player state, so no stale items are shown before the correct ones are loaded.
Fix Implementation
I added a
reset()method to theItemInHandRendererwhich cleans up the player's held item state when a world is unloaded.AI Use Disclosure
I used AI as a tool to navigate the codebase and locate the areas that needed fixing, then implemented changes myself and tested the new behavior.
How it looked before:
2026-03-07.20-51-10.mp4
How it looks after:
2026-03-07.20-54-23.mp4