fix: logo rendering order after closing host options#907
Open
Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Open
fix: logo rendering order after closing host options#907Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Conversation
Contributor
Author
Minecraft.2026-03-08.01-39-25.webm |
Alezito2008
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a UI rendering order bug where the game logo appeared darkened after opening and closing the Host Options menu.
Changes
Previous Behavior
When opening the pause menu after closing the host options menu, the background dimming effect would render on top of the game logo, making it look dark.
Root Cause
UIScene_InGameInfoMenu::handleDestroywas callingremoveComponent(eUIComponent_MenuBackground). This forced theUILayerto recreate and re-insert the background at the end of the m_components vector, placing it above the Logo in the draw call stack.New Behavior
The logo now correctly renders on top of the background at all times, regardless of which menus were previously opened.
Fix Implementation
Removed the unnecessary
removeComponentcall fromUIScene_InGameInfoMenu::handleDestroyAI Use Disclosure
No
Related Issues