✨ Merge Go builder code into this repo#50
Merged
Conversation
ianlewis
approved these changes
May 17, 2022
Member
There was a problem hiding this comment.
I did a quick pass but I assume this is mostly a just a copy of the existing repo.
Though, it seems like one dependency is missing from go.sum?
https://github.com/slsa-framework/slsa-github-generator/runs/6476273227?check_suite_focus=true
Collaborator
Author
|
correct, just a copy. I'll fix the dependency problem before merging (slsa-framework/slsa-github-generator-go#129). |
Member
Ok, thanks. I did see some changes like merging the pre-submit yaml, but I'm comfortable that I'm not missing anything then. |
laurentsimon
force-pushed
the
feat/mergego
branch
from
7fc70e8 to
137b975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #36