Workflow name#43
Merged
Merged
Conversation
joshuagl
approved these changes
May 9, 2022
Member
joshuagl
left a comment
There was a problem hiding this comment.
Code looks good. Before and after examples of the provenance would make PRs like this easier to review.
Member
|
Agreed. I can't really review because I'd need to see an example to be sure that it's correct. Speaking of which, what is the plan for unit tests? That would make these PRs much easier to review. |
Member
Author
|
Sure I can add tests. It was smallish change but maybe tests are warranted. I'll also remember to add before/after notes to the PR description for future PRs. |
Member
Author
|
@joshuagl @MarkLodato I added a before/after example and a simple unit test for the entrypoint. PTAL |
ianlewis
commented
May 10, 2022
Collaborator
|
Feel free to merge. If all works well, the e2e test will pick the change and fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
Before the change the
predicate.invocation.configSource.entryPointhas the name of the user workflow (not the reusable workflow) specified in the workflow yaml:After this change it's a path to the workflow: