Skip to content

Workflow name#43

Merged
ianlewis merged 13 commits into
slsa-framework:mainfrom
ianlewis:workflow-name
May 11, 2022
Merged

Workflow name#43
ianlewis merged 13 commits into
slsa-framework:mainfrom
ianlewis:workflow-name

Conversation

@ianlewis
Copy link
Copy Markdown
Member

@ianlewis ianlewis commented May 9, 2022

Fixes #11

Before the change the predicate.invocation.configSource.entryPoint has the name of the user workflow (not the reusable workflow) specified in the workflow yaml:

"predicate": {
    "invocation": {
        "entryPoint": "SLSA provenance"
        ...
      },
...

After this change it's a path to the workflow:

"predicate": {
    "invocation": {
      "configSource": {
        "entryPoint": "https://github.com/ianlewis/actions-test/.github/workflows/provenance-only.yml"
        ...
      },
...

Copy link
Copy Markdown
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Before and after examples of the provenance would make PRs like this easier to review.

@MarkLodato
Copy link
Copy Markdown
Member

Agreed. I can't really review because I'd need to see an example to be sure that it's correct.

Speaking of which, what is the plan for unit tests? That would make these PRs much easier to review.

@ianlewis
Copy link
Copy Markdown
Member Author

Sure I can add tests. It was smallish change but maybe tests are warranted. I'll also remember to add before/after notes to the PR description for future PRs.

@ianlewis
Copy link
Copy Markdown
Member Author

@joshuagl @MarkLodato I added a before/after example and a simple unit test for the entrypoint. PTAL

Comment thread slsa/github.go Outdated
@laurentsimon
Copy link
Copy Markdown
Collaborator

Feel free to merge. If all works well, the e2e test will pick the change and fail

@ianlewis ianlewis merged commit dcacbd7 into slsa-framework:main May 11, 2022
@ianlewis ianlewis deleted the workflow-name branch July 27, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entrypoint is the workflow name

4 participants