Allocation to use mmap#180
Open
skx wants to merge 3 commits into
Open
Conversation
This ensures that we have a stable internal API; next up move to MMAP.
This works, but it is painfully slow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request moves from using a null area in the BSS section (8Gb) for our memory allocation to using
mmapto allocate an area of RAM at startup (16gb).In order to make this transition I first created a general-purpose "allocate" routine and moved all code to use that. Then updated it to use mmap as the backing store, and added bound checking to it
The plus side is this works. The downside is that performance seems to be very variable:
Need to investigate before merging, and compare to
mainand/or the previous release.