Skip to content

Fixing files warnings#105

Closed
vsoch wants to merge 2 commits intomasterfrom
fix/files
Closed

Fixing files warnings#105
vsoch wants to merge 2 commits intomasterfrom
fix/files

Conversation

@vsoch
Copy link
Copy Markdown
Member

@vsoch vsoch commented May 24, 2019

This will fix issues #101 and #102, specifically:

  • we check that the parent of a files source or destination AND the source destination doesn't exist to issue a warning. Previously, we were issuing a warning if the destination didn't exist, which isn't logical. It won't :)
  • we give the user a warning for any file expansions (*) as Singularity doesn't allow this.

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Copy Markdown
Member Author

vsoch commented May 24, 2019

@Flamefire would you care to test this? It addresses your two issues about files warnings.

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Copy Markdown
Member Author

vsoch commented May 25, 2019

okay, just checking the source now!

@vsoch
Copy link
Copy Markdown
Member Author

vsoch commented May 27, 2019

The lines in this PR were copy pasted by @Flamefire, now under his name. Closing.

@vsoch vsoch closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant