Open
Conversation
I think the duplicate removal logic is excessive it may hide issues with the save/restore procces
Owner
|
Thanks! Can anyone who uses WP put this through their paces? I'll ping the Discord to see. |
Contributor
Author
|
For those who want to test it, it's better to use console command: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time working on actors that move between WorldPartition cells, tests in my project look fine, but I think more testing is needed. Currently, for the subsystem to start tracking an actor, it must implement a separate interface so that SPUD can distinguish it during the save and restore process, there might be a better way to handle this.
I kept
USpudRuntimeStoredActorComponent, right now it only subscribes and unsubscribes its owner to/from subsystem tracking.