Skip to content

Updated Runner and Removed Deprecated Code#105

Merged
omarghatasheh merged 1 commit into
mainfrom
update/ios-cicd
Jun 19, 2026
Merged

Updated Runner and Removed Deprecated Code#105
omarghatasheh merged 1 commit into
mainfrom
update/ios-cicd

Conversation

@MusaMisto

@MusaMisto MusaMisto commented Jun 19, 2026

Copy link
Copy Markdown
Member

Updated the Upload runner to use the Linux runner instead.

Summary by CodeRabbit

  • Refactor
    • Simplified iOS TestFlight deployment by removing support for legacy upload methods; now exclusively uses App Store Connect REST API.
    • Updated build environment configuration for consistency.
    • Streamlined credential handling and removed unnecessary input parameters.

@MusaMisto MusaMisto self-assigned this Jun 19, 2026
@MusaMisto MusaMisto added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e8cac02-175c-4f48-9ced-996242fd46bc

📥 Commits

Reviewing files that changed from the base of the PR and between 1ecffc1 and 475c438.

📒 Files selected for processing (2)
  • .github/workflows/ios-build.yml
  • workflow-templates/ios-app.yml
💤 Files with no reviewable changes (1)
  • workflow-templates/ios-app.yml

📝 Walkthrough

Walkthrough

The reusable iOS build workflow removes all altool/transporter upload support, restricts upload-tool to appstoreapi only with a runtime failure for any other value, switches the release_with_environment job to ubuntu-latest, removes the Xcode setup step, and updates credential decoding and file-size commands to GNU tooling. The caller template drops the now-redundant explicit upload-tool: appstoreapi override.

Changes

iOS TestFlight: restrict to App Store Connect REST API on ubuntu-latest

Layer / File(s) Summary
Public contract: input, secret, and header docs
.github/workflows/ios-build.yml
upload-tool input restricted to appstoreapi only (altool/transporter references removed), appstore-key-format input removed, appstore-api-private-key-base64 secret description updated, and workflow header comments reflect REST-API-only upload path.
Release job: ubuntu-latest runner, Xcode removal, credential validation
.github/workflows/ios-build.yml
release_with_environment switches from ${{ inputs.macos-runner }} to ubuntu-latest, removes Xcode setup, adds UPLOAD_TOOL env to the validate-credentials step, and fails fast with a migration message for any non-appstoreapi value.
Credential decode, stat, and upload steps unified to REST-only path
.github/workflows/ios-build.yml
Decode API key step loses its appstoreapi-conditional guard and switches base64 -D to base64 -d for GNU compatibility; Prepare upload switches to GNU stat -c%s; Confirm upload loses its upload-tool conditional; the Upload (altool) step is deleted entirely; upload-step comments updated.
Caller template: remove explicit upload-tool override
workflow-templates/ios-app.yml
development and production job configurations drop upload-tool: appstoreapi, relying on the reusable workflow's now-enforced default.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • simplify9/.github#28: Adds iOS TestFlight reusable workflows that pass upload-tool and appstore-key-format inputs — directly coupled to the inputs this PR removes and restricts.
  • simplify9/.github#84: Also updates the iOS TestFlight upload workflow to use upload-testflight-build@v4 with base64-decoded appstore-api-private-key-base64, removing prior altool/transporter paths — same migration trajectory.
  • simplify9/.github#87: Modifies upload-tool defaults/validation and appstore-key-format/key decoding in the same reusable workflow — directly overlapping with the inputs and steps changed here.

Suggested reviewers

  • omarghatasheh

Poem

🐇 Hop, hop, no more altool to drop,
The rabbit switched runners — ubuntu on top!
One key, one path, base64 -d it goes,
stat -c%s now, as the ubuntu wind blows.
The pipeline is clean, the API reigns free —
AppStoreConnect REST, just the way it should be! 🍎

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Updated Runner and Removed Deprecated Code' only partially addresses the main changes. While it mentions runner updates, it doesn't reflect the significant API migration (appstoreapi-only), removal of altool support, or key input changes. Consider a more specific title like 'Switch iOS TestFlight upload to REST API only and migrate to Ubuntu runner' to better reflect the scope of changes and migration from altool.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update/ios-cicd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omarghatasheh omarghatasheh merged commit bd09442 into main Jun 19, 2026
2 checks passed
@omarghatasheh omarghatasheh deleted the update/ios-cicd branch June 19, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants