Skip to content

Kubernetes monolith#932

Open
Enkidu93 wants to merge 3 commits intomainfrom
kubernetes_monolith
Open

Kubernetes monolith#932
Enkidu93 wants to merge 3 commits intomainfrom
kubernetes_monolith

Conversation

@Enkidu93
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 commented Apr 29, 2026

Fixes #922

I've tested this on internal-qa and it seems to be working fine, but I'd like to do a bit more testing.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit April 29, 2026 20:00
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems simple enough. Have we gotten any feedback from LTOps on the CPU and memory limits?

@ddaspit reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93
Copy link
Copy Markdown
Collaborator Author

Enkidu93 commented May 1, 2026

It seems simple enough. Have we gotten any feedback from LTOps on the CPU and memory limits?

@ddaspit reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

Still talking to Greg. It looks like memory is the place we should try to use as little as possible. Greg is chill with there being no limits on the CPU resources (which I actually already removed as per his request last month). He has OK'd the values in this PR as a good starting place and says we can monitor it.

@Enkidu93 Enkidu93 force-pushed the kubernetes_monolith branch from a4a749c to b457229 Compare May 7, 2026 12:48
@Enkidu93
Copy link
Copy Markdown
Collaborator Author

Enkidu93 commented May 7, 2026

Alright, I've tested this now more completely. Here's how I've tested it:

  1. Ran a production-copy build on int-qa using recreate_build.py.
  2. Confirmed that the build ran successfully and that the db was populated.
  3. Migrated the db using the migration commands in the relevant issue.
  4. Confirmed that the new db set-up looks correct and that data has been migrated.
  5. Deployed the new monolith int-qa and made sure it was healthy.
  6. Confirmed that the db still looked correct (still has migrated docs etc.).
  7. Made sure I can successfully download a datafile created before the migration.
  8. Ran the production build again on the int-qa (now monolith).
  9. Confirmed that the new build ran successfully.
  10. Confirmed that I can delete engines (created pre and post migration) and consequently the relevant serval and serval.machine documents are deleted.

@ddaspit @pmachapman Anything else you think we should test?

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers everything I can think of.

@ddaspit made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Kubernetes configuration for monolith

2 participants