Conversation
ddaspit
left a comment
There was a problem hiding this comment.
It seems simple enough. Have we gotten any feedback from LTOps on the CPU and memory limits?
@ddaspit reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Still talking to Greg. It looks like memory is the place we should try to use as little as possible. Greg is chill with there being no limits on the CPU resources (which I actually already removed as per his request last month). He has OK'd the values in this PR as a good starting place and says we can monitor it. |
a4a749c to
b457229
Compare
|
Alright, I've tested this now more completely. Here's how I've tested it:
@ddaspit @pmachapman Anything else you think we should test? |
ddaspit
left a comment
There was a problem hiding this comment.
This covers everything I can think of.
@ddaspit made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Fixes #922
I've tested this on internal-qa and it seems to be working fine, but I'd like to do a bit more testing.
This change is