Skip to content

LT-22500 Crash after deleting 'new operation' item in Allomorph Generator dialog #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyBlack merged 2 commits into from
Apr 23, 2026
Merged

LT-22500 Crash after deleting 'new operation' item in Allomorph Generator dialog #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e38aa19
LT-22500: Match chooser box was too small
AndyBlack Apr 23, 2026
6c8e06f
LT-22500: fix crash when replace op ref but no replace op
AndyBlack Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions Src/Utilities/AlloVarGen/AllomorphGeneratorDll/AlloGenFormBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,9 +1091,17 @@ protected virtual void lBoxOperations_SelectedIndexChanged(object sender, EventA
if (ActionOp.ReplaceOpRefs.Count == 0)
{
// need at least one replace action
Replace replace = CreateNewReplace();
AlloGens.AddReplaceOp(replace);
lBoxReplaceOps.Items.Add(replace);
if (AlloGens.ReplaceOperations.Count > 0)
{
ActionOp.ReplaceOpRefs.Add(AlloGens.ReplaceOperations.ElementAt(0).Guid);
}
else
{
Replace replace = CreateNewReplace();
AlloGens.AddReplaceOp(replace);
lBoxReplaceOps.Items.Add(replace);
}
MarkAsChanged(true);
}
StemName = ActionOp.StemName;
tbStemName.Text = StemName.Name;
Expand All @@ -1105,13 +1113,23 @@ protected virtual void lBoxOperations_SelectedIndexChanged(object sender, EventA
protected void RefreshReplaceListBox()
{
lBoxReplaceOps.Items.Clear();
List<string> brokenRefs = new List<string>();
foreach (string guid in ReplaceOpRefs)
{
Replace replace = AlloGens.FindReplaceOp(guid);
if (replace != null)
{
lBoxReplaceOps.Items.Add(replace);
}
else
{
brokenRefs.Add(guid);
}
}
foreach (string guid in brokenRefs)
{
ReplaceOpRefs.Remove(guid);
MarkAsChanged(true);
}
if (ReplaceOpRefs.Count > 0)
lBoxReplaceOps.SetSelected(0, true);
Expand Down
2 changes: 1 addition & 1 deletion Src/Utilities/AlloVarGen/AllomorphGeneratorDll/SimpleMatchDlgAlloGen.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
<value>8, 19</value>
</data>
<data name="$this.ClientSize" type="System.Drawing.Size, System.Drawing">
<value>488, 172</value>
<value>823, 255</value>
</data>
<data name="$this.Text" xml:space="preserve">
<value>Match for forms containing...</value>
Expand Down
Loading