Add Useful Properties, Deprecate getters#115
Closed
gregparkes wants to merge 2 commits intosigmf:mainfrom
Closed
Conversation
Collaborator
|
I see your implementation, but I believe we can make this dynamic and more clear. I'm going to open a different PR in a moment and mention you. Take a look I think it may be a better approach. |
Collaborator
|
Closing since we will merge #116 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #102
Unfortunately, adding a deprecation to
SigMFFile.get_num_channels()requires Python 3.13 to usewarnings.deprecated, and as I understand we want backwards-compatibility to Python 3.8, so i've left get_num_channels in place.All unit tests (py38, py311 and py313) pass on my system.