SG-34087 - Rebranding#321
Merged
Merged
Conversation
juanburgosautoglb
requested review from
carlos-villavicencio-adsk and
julien-lang
julien-lang
requested changes
Jan 17, 2024
julien-lang
reviewed
Jan 24, 2024
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
Please make sure to respect the line width rule when exists in the file
julien-lang
requested changes
Feb 1, 2024
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
Please check last changes. I see a lof of "eaten spaces"
julien-lang
requested changes
Feb 6, 2024
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
A few minor comments. We are almost there.
juanburgosautoglb
force-pushed
the
ticket/SG-34087-rebranding
branch
from
ab0aeb2 to
5212f8a
Compare
julien-lang
reviewed
Feb 9, 2024
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
Looks good. I checked the branch and I still see 2 references to ShotGrid:
- setup.py
- software_credits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all the shotgrid/shotgun occurrences in the repository.