Whitelisted custom properties filtration#112
Merged
Merged
Conversation
…-properties-filtration
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…560-CustomPropertiesIssuesFiltering
| isPreviewEnabled, | ||
| handleIsPreviewEnabled, | ||
| }) => { | ||
| const [op, setOp] = useState<"gt" | "lt" | "eq" | "ne" | "isbetween" | "isnull" | "isnotnull">("gt"); |
| payload = `${groupKey}:${from}`; | ||
| break; | ||
|
|
||
| case "ne": // not on |
| <div className="mt-4 w-full"> | ||
| <div className="flex items-center space-x-2"> | ||
| {["gt", "lt", "eq", "ne"].includes(op) && ( | ||
| <input |
| handleIsPreviewEnabled, | ||
| }) => { | ||
| const [op, setOp] = useState<"gt" | "lt" | "eq" | "ne" | "isbetween" | "isnull" | "isnotnull">("gt"); | ||
| const [val1, setVal1] = useState<number | "">(""); |
There was a problem hiding this comment.
remove string support in states
| handleIsPreviewEnabled, | ||
| }) => { | ||
| const [op, setOp] = useState<"gt" | "lt" | "eq" | "ne" | "isbetween" | "isnull" | "isnotnull">("gt"); | ||
| const [val1, setVal1] = useState<number | "">(""); |
There was a problem hiding this comment.
val1 -> from : val2 -> to
…e into Whitelisted-custom-properties-filtration
…b.com:shipsy/plane into Whitelisted-custom-properties-filtration
…e into Whitelisted-custom-properties-filtration
|
|
||
| groupedUniqueCustomProperties = {key: list(values) for key, values in groupedCustomProperties.items()} | ||
| unique_values_list = [{"key": k, "values": v} for k, v in groupedUniqueCustomProperties.items()] | ||
| bucket = groupedCustomProperties.setdefault( |
There was a problem hiding this comment.
Please check if we can use group by with django query ,
Grouping collections here is not saclable approach
sumarpreet-kaur-shipsy
approved these changes
May 1, 2025
…b.com:shipsy/plane into Whitelisted-custom-properties-filtration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.