Skip to content

Move SFX settings controls to Kotlin - #286

Merged
shareui merged 2 commits into
mainfrom
xarmaq
Jul 29, 2026
Merged

Move SFX settings controls to Kotlin#286
shareui merged 2 commits into
mainfrom
xarmaq

Conversation

@xarmaq

@xarmaq xarmaq commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • moved the SFX expandable header and child checkbox creation out of settings.py
  • added the Kotlin-backed SfxNative builders for expandable items and the volume slider
  • connected the new builders through sfx.py and dexLoader.py
  • shipped the generated sfx.dex
  • kept a Python fallback for hosts where the native controls cannot be loaded

Why

The SFX page previously owned its controls indirectly through the large shared settings module. Moving the controls to the Kotlin dex reduces Python-to-Java UI construction and keeps SFX-specific code inside the SFX module.

Validation

  • compiled all Python sources
  • compiled the Kotlin sources with Kotlin 2.0.21
  • generated and inspected sfx.dex with R8/D8
  • built PackIt-0.0.0-rc.652-3.11.eaf with elyb build -c 2 -nf -v

@shareui
shareui marked this pull request as ready for review July 29, 2026 12:04
@shareui
shareui merged commit 679451f into main Jul 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants