Use per model TF_Status instead of the global one#201
Merged
serizba merged 1 commit intoserizba:masterfrom May 26, 2022
Merged
Conversation
This avoids the "static initialization order fiasco" when people build cppflow into a library.
Contributor
Author
|
@serizba I only tested this on Linux (gcc), but many of these issues were reported on Windows related to building into a dll. I am not sure if there is a good way to test it. |
Owner
|
Thanks @ljn917 I haven't tried on Windows, but I will merge anyway, as I don't think this PR may create additional problems. People from the related issues can comment if this fixed their errors. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the initialization order issues when people build cppflow into a library, e.g. a dll.
Should fix #132, #195, #163, #131, #190, #154