feat: Build URL with multiple instances of the same param#136
feat: Build URL with multiple instances of the same param#136thinkingserious merged 2 commits intosendgrid:mainfrom
Conversation
|
|
|
Regex credit to https://stackoverflow.com/a/8171667 |
|
@thinkingserious per sendgrid/sendgrid-php#828 is the CLA still a thing? |
|
Since there has been no activity on this issue since March 1, 2020, we are closing this issue. If you are still interested in moving this PR forward, please feel free to reopen. Thank you! |
|
@thinkingserious I was waiting on a response to this pull request, and I'm happy to do what's needed to move it forward if you have any feedback. I would like to reopen it, but I don't appear to have the permission to do so. |
shwetha-manvinkurke
left a comment
There was a problem hiding this comment.
LGTM! Just gotta merge changes with main
|
@shwetha-manvinkurke thanks for the review! I fixed the leading space in the doc block and rebased against |
Checklist
Short description of what this PR does:
A number of APIs accept what is documented as "array of string". In practice, it's a number of instances of identical URL arguments with different values.
For example from retrieving subuser reputations:
I updated the
buildUrl()function to accept nested arrays so that you could form the above URL with the query:If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.